Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

active attribute for tabs breaks #61

Closed
LFDM opened this issue Jun 19, 2014 · 5 comments
Closed

active attribute for tabs breaks #61

LFDM opened this issue Jun 19, 2014 · 5 comments

Comments

@LFDM
Copy link

LFDM commented Jun 19, 2014

Using Angular 1.2.17 I run into problems using the active attribute for tabs.

The culprit seems to be this line:
https://github.com/madmimi/angular-foundation/blob/09d18584ab6112393acae4d81a72bf5211ba7683/src/tabs/tabs.js#L206

At the point of the first invocation of this watcher, setActive is undefined - in fact, it seems to be always undefined for me.

I am not sure how the setActive function is working - it appears though that if I just comment it out, everything works fine.

@jbrowning
Copy link
Member

Could you please create a plunkr demonstrating this issue?

@MJLang
Copy link

MJLang commented Aug 11, 2014

+1

Same issue here, using Angular 1.2.20

@jbrowning
Copy link
Member

Sorry, not able to replicate in the tab demo on plunkr for either 1.2.17 or 1.2.20. If either of you could create a plunk demonstrating this issue, that'd be great.

@LFDM
Copy link
Author

LFDM commented Aug 11, 2014

Sorry for the lazy response, Jeff, currently not much spare time, but will
try to reproduce later this week.

On Mon, Aug 11, 2014 at 2:59 PM, Jeff Browning [email protected]
wrote:

Sorry, not able to replicate in the tab demo on plunkr for either 1.2.17
or 1.2.20. If either of you could create a plunk demonstrating this issue,
that'd be great.


Reply to this email directly or view it on GitHub
https://github.com/madmimi/angular-foundation/issues/61#issuecomment-51776167
.

@jbrowning
Copy link
Member

👍 thanks

jbrowning added a commit that referenced this issue Oct 24, 2014
chinook25 pushed a commit to drugis/angular-foundation that referenced this issue Sep 29, 2017
feat(drilldownMenu): Add automatic resizing, an API, and events.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants