Skip to content

Introduce KafkaEngine support #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jimenezj8
Copy link

Adds limited official support for KafkaEngine as requested in this ticket. Although documentation was added for extending clickhouse-sqlalchemy with custom engines downstream, it would be beneficial to the community to add first-class support.

For now, this PR adds logic to the DDLCompiler in order to generate CREATE TABLE statements using the new engine. This is an experimental engine, as stated by the ClickHouse docs. Tables with this engine should also never be read from directly - the query will simply fail, as noted by ClickHouse docs.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Ensure PR doesn't contain untouched code reformatting: spaces, etc.
  • Run flake8 and fix issues.
  • Run pytest no tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.

@jimenezj8
Copy link
Author

@xzkostyan please let me know how to proceed with this PR, when you have the opportunity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant