Skip to content

Fix NPE in webgl renderer #4326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Fix NPE in webgl renderer #4326

merged 1 commit into from
Dec 16, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Dec 16, 2022

Theory is this can happen when a resize down happens as end will be too big

See microsoft/vscode#166878
Fixes #4314

Theory is this can happen when a resize down happens as end will be too big

See microsoft/vscode#166878
@Tyriar Tyriar added this to the 5.1.0 milestone Dec 16, 2022
@Tyriar Tyriar self-assigned this Dec 16, 2022
@Tyriar Tyriar enabled auto-merge December 16, 2022 18:42
@Tyriar Tyriar merged commit bcdbb61 into xtermjs:master Dec 16, 2022
@Tyriar Tyriar deleted the 166878 branch December 16, 2022 18:59
@jerch
Copy link
Member

jerch commented Dec 17, 2022

@Tyriar Would it be worth to further track down the reason for the lines numbers provided being off?

I'd suspect a race condition from resizing as well, but doesnt that mean that by opposite resizing the numbers are also off? This ofc would not run into an NPE, but still apply wrong numbers for whatever reason _updateModel was called, prolly missing model updates (eg. from resizing - skipping updates on higher/further down lines).

@Tyriar
Copy link
Member Author

Tyriar commented Dec 17, 2022

I don't think the opposite is a concern as a full screen update would have been requested after the resize, I guess we could remove this workaround and then validate the end value before using it in render service or debouncer?

@Tyriar
Copy link
Member Author

Tyriar commented Dec 17, 2022

Reopened the issue to do that, that way we would still get the exception if something else is happening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addon-webgl exception at line.loadCell(x, cell), line undefined
2 participants