Skip to content

Add getOption API #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 21, 2016
Merged

Add getOption API #282

merged 2 commits into from
Sep 21, 2016

Conversation

parisk
Copy link
Contributor

@parisk parisk commented Sep 21, 2016

Complements #272.

Tyriar
Tyriar reviewed Sep 21, 2016
View reviewed changes
src/xterm.js
throw new Error('No option with key "' + key + '"');
}

if (typeof this.options[key] != 'undefined') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer !== as it's more strict

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 53e8ac9.

@Tyriar
Copy link
Member

Tyriar commented Sep 21, 2016

Lgtm apart from the small comment

@parisk parisk merged commit 76a686b into master Sep 21, 2016
@Tyriar Tyriar deleted the get-option branch October 31, 2016 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parisk @Tyriar