Skip to content

Added Zulip as a sponsor and added ref data #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 13, 2025
Merged

Conversation

nwlandry
Copy link
Collaborator

This fixes #660.

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.50%. Comparing base (18de14b) to head (691e97a).
Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #662   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files          64       64           
  Lines        5005     5005           
=======================================
  Hits         4680     4680           
  Misses        325      325           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nwlandry nwlandry requested a review from maximelucas February 10, 2025 19:48
@maximelucas
Copy link
Collaborator

Thanks a lot Nich. I like the XGI-DATA tags.

About the new support section on the homepage, it's nice to show off support, but I think it takes too much space and the logos are big and don't fit so well with the rest so it's not super pretty. Also since there's only one per category, I wouldn't differentiate between financial and infrastructural.

I would personally opt for a more minimal version. Ideas:

  1. Just one line of text mentioning NSF and Zulip.
  2. Just one line with the two logos but much smaller (and in black and white or somth?)
  3. Just "Check out who supports XGI" with a link to another page with more details
  4. Nothing on home page but somthing on a separate page.

What do you think?

@nwlandry
Copy link
Collaborator Author

What about a variant of 3? A "Support" section with the NSF and Zulip logos and a "see more" link linking to a separate page

@nwlandry
Copy link
Collaborator Author

I think I implemented all of your suggestions, @maximelucas!

@nwlandry nwlandry merged commit ee0908e into main Feb 13, 2025
17 checks passed
@nwlandry nwlandry deleted the add-zulip-and-refs branch February 13, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "Using XGI-DATA" section?
2 participants