[HID] Added option to turn off vibration #1820
Conversation
src/xenia/kernel/xam/xam_input.cc
Outdated
| if (!cvars::enable_vibration) { | ||
| vibration->left_motor_speed = 0; | ||
| vibration->right_motor_speed = 0; | ||
| } | ||
| auto input_system = kernel_state()->emulator()->input_system(); | ||
| return input_system->SetState(user_index, vibration); |
There was a problem hiding this comment.
Ideally this should probably be handled by a proxy function in the HID subsystem, I think, also with the possibility of toggling it at runtime, zeroing the current speed when vibration is disabled mid-game from the UI, and remembering the speeds from the latest XamInputSetState call and applying them when vibration is re-enabled.
There was a problem hiding this comment.
I am unsure if it is necessary to have the rumble speed remembered. What guest do you now that has active rumble (at the same level) for more than a second? (while there is active user input)
There was a problem hiding this comment.
Environmental effects such as thunder possibly, big explosions in scripted scenes.
There was a problem hiding this comment.
Overall, statically, in the XInput API, there are no requirements of how frequently the function needs to be called so that we can treat a specific maximum length as "negligible". By only dropping calls, we're introducing arbitrary behavior not present in the API specification, as well as unspecified constraints on arbitrarily chosen dynamic state (when the game performs the XInputSetState calls, and the point in time when the user has toggled vibration). A properly isolated implementation should store the desired vibration level, and perform the toggling with the event flow similar to that of a new keystroke somewhat arriving from the UI thread in the winkey HID backend (with the difference that it should be applied immediately once no race condition between the toggling and a new SetState is possible, not cached until the next SetState).
src/xenia/kernel/xam/xam_input.cc
Outdated
| if (!cvars::enable_vibration) { | ||
| vibration->left_motor_speed = 0; | ||
| vibration->right_motor_speed = 0; | ||
| } | ||
| auto input_system = kernel_state()->emulator()->input_system(); | ||
| return input_system->SetState(user_index, vibration); |
There was a problem hiding this comment.
I am unsure if it is necessary to have the rumble speed remembered. What guest do you now that has active rumble (at the same level) for more than a second? (while there is active user input)
Gliniak
force-pushed
the
disablePositiveVibes
branch
2 times, most recently
from
2d5a50b to
9bd635e
Compare
src/xenia/hid/input_system.cc
Outdated
| @@ -62,10 +64,14 @@ X_RESULT InputSystem::GetState(uint32_t user_index, X_INPUT_STATE* out_state) { | |||
| X_RESULT InputSystem::SetState(uint32_t user_index, | |||
| X_INPUT_VIBRATION* vibration) { | |||
| SCOPE_profile_cpu_f("hid"); | |||
|
|
|||
| X_INPUT_VIBRATION* modified_vibration = new X_INPUT_VIBRATION(); | |||
There was a problem hiding this comment.
This is a memory leak 🥲
Just do X_INPUT_VIBRATION modified_vibration; to allocate it on the stack and pass &modified_vibration
There was a problem hiding this comment.
Unless you're already adding the scale for the vibration, you can just return immediately from the function, by the way — you don't need to set vibration to 0 if you never set it to anything other than 0 anyway.
There was a problem hiding this comment.
Smack me with a hammer for my stupidity... I dunno what I was thinking and why I thought it will be fine
There was a problem hiding this comment.
Well, if this var can someday be changed from gui and controller is currently rumbling, itll never stop iIrc
There was a problem hiding this comment.
The GUI button can explicitly stop the current vibration.
Gliniak
force-pushed
the
disablePositiveVibes
branch
from
9bd635e to
409bb6a
Compare
Gliniak
force-pushed
the
disablePositiveVibes
branch
from
409bb6a to
2868489
Compare
Gliniak
force-pushed
the
disablePositiveVibes
branch
from
2868489 to
613f5eb
Compare
Some games in x360 lib doesn't allow to turn off vibrations directly from the game. That option is for these cases.
I tried it in two more ways.
But they didn't worked 😢