CA-411477: Fix SM API version check failure #6552
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindig
reviewed
Jun 24, 2025
lindig
approved these changes
Jun 24, 2025
BengangY
force-pushed
the
private/bengangy/CA-411477
branch
from
8ccb08f to
196b5f4
Compare
psafont
approved these changes
Jun 24, 2025
When shutdown a VM, xapi will check SM API version to decide if to call `post_deactivate_hook`. But if the SR has already been unplugged, the checking will fail. Solution: Check if the dp of the SR still exists. If not, skip the SM API checking. Signed-off-by: Bengang Yuan <[email protected]>
BengangY
force-pushed
the
private/bengangy/CA-411477
branch
from
196b5f4 to
ec612ae
Compare
|
I changed the solution as there is another function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When shutdown a VM, xapi will check SM API version to decide if to call
post_deactivate_hook. But if the SR has already been unplugged, the checking will fail.Solution:
Check if the plugin of the SR still exists. If not, skip the SM API checking.