Access Control Script #578
Conversation
| contract: config.poolFactoryAddress, | ||
| role: STAKE_KEYS_ADMIN_ROLE, | ||
| func: REVOKE_ROLE, | ||
| account: "0xAccountAddressHere" |
There was a problem hiding this comment.
This needs to be the TinyKeyAirdrop contract address
0x0209a0C0Abfe82916DF492D121667aCcA26C7eb0
| case REVOKE_STAKE_ADMIN_FUNC: | ||
| tx = await contract.revokeStakeKeysAdminRole(job.account); | ||
| break; |
There was a problem hiding this comment.
I just noticed this on the last review. This function on the poolfactory should not exists it just wrappes around revokeRole and we do not need to have the dedicated case here.
Change is not required, however we should be aware, that the function revokeStakeKeysAdminRole is not within the AccessControl interface and most likely will be removed from the poolFactory which would make this case unusable.
| contract: config.poolFactoryAddress, | ||
| role: STAKE_KEYS_ADMIN_ROLE, | ||
| func: REVOKE_STAKE_ADMIN_FUNC, | ||
| account: "0x7C94E07bbf73518B0E25D1Be200a5b58F46F9dC7" |
There was a problem hiding this comment.
This needs to be the TinyKeyAirdrop contract address
0x0209a0C0Abfe82916DF492D121667aCcA26C7eb0
The deployer does not have the STAKE_ADMIN_ROLE on the PoolFactory
Ticket
updateRoleOwners.mjsscript that will iterate over a configured list of contracts and update Access Control roles accordingly.transferOwnership.mjsscript that will update ownership of the beacon proxy contract.