Add mintTo Function to Node License Contract. #432

XDapps · 2024-09-26T15:15:10Z

Updated NodeLicense contract by adding a new mintTo function that allows the minter to pass in the address that the license should be minted to.

Testing: tested with test cases. Also deployed on Sepolia here .

Completed a test using mintTo on Sepolia and confirmed the recipient received the license via this transaction.

…cense

XDapps · 2024-09-26T15:17:30Z

infrastructure/smart-contracts/test/NodeLicenseTinyKeys.mjs

@@ -98,7 +98,7 @@ export function NodeLicenseTinyKeysTest(deployInfrastructure, poolConfigurations
            await xai.connect(addr1).approve(await nodeLicense.getAddress(), priceInXai);

            // Mint an NFT
-            await nodeLicense.connect(addr1).mintWithXai(1, "", false, priceInEther);
+            await nodeLicense.connect(addr1).mintWithXai(1, "", false, priceInXai);


These test cases were failing due to this bug with the wrong value.

They were never passing ?

I'm going from memory, but I think there was originally a bug in the contract around an operator being reversed in this logic. That was caught and fixed when the contract was deployed on Sepolia for testing, but seems the test cases were never updated.

I think I remember when we found the bug on Sepolia, you asked me why the tests didn't catch it. and It seems this was the reason.

I think the operator part is mixed up but I do remember. This was caught in the audit, we were not expecting the final price to be higher and had to reverse that check. So this makes sense to me now, thanks.

…ithub.com/xai-foundation/sentry into feat/jh/tk/add-mint-function-node-license

XDapps · 2024-09-26T15:21:25Z

infrastructure/smart-contracts/test/Fixture.mjs

Only ran test cases related to NodeLicense tests as the other test cases are still in the process of being cleaned up in another story.

craigbranscom · 2024-09-27T19:39:26Z

infrastructure/smart-contracts/contracts/upgrades/node-license/NodeLicense8.sol

+     * @param _amount The amount of tokens to mint.
+     * @param _promoCode The promo code.
+     */
+    function mintTo(address _mintToAddress, uint256 _amount, string calldata _promoCode) public payable {


We should double check the function name doesn't need to be mint instead of mintTo since this change is for a third party integration. If no change is needed let me know and I'll approve.

I agree, I actually tried to just use mint with a different function signature and got errors because crossmint couldn't seem to differentiate between them, so I changed to mintTo and was able to get it to work. I have tested and confirmed that it works with crossmint. 👍

…cense

CryptITAustria · 2024-10-01T16:52:19Z

infrastructure/smart-contracts/contracts/xai-subsidy/Forwarder.sol

Again ? I see this in the thrid PR now... XD

It seems unfortunately, the fix was not yet merged when this branch was created...

CryptITAustria · 2024-10-01T16:53:23Z

infrastructure/smart-contracts/test/NodeLicenseTinyKeys.mjs

@@ -98,7 +98,7 @@ export function NodeLicenseTinyKeysTest(deployInfrastructure, poolConfigurations
            await xai.connect(addr1).approve(await nodeLicense.getAddress(), priceInXai);

            // Mint an NFT
-            await nodeLicense.connect(addr1).mintWithXai(1, "", false, priceInEther);
+            await nodeLicense.connect(addr1).mintWithXai(1, "", false, priceInXai);


They were never passing ?

CryptITAustria · 2024-10-01T16:55:16Z

infrastructure/smart-contracts/test/NodeLicenseTinyKeys.mjs

+        it("Check minting an NFT and receiving it with ETH using the MintTo Function", async function() {
+            const {nodeLicense, addr1, addr2, fundsReceiver} = await loadFixture(deployInfrastructure);
+            const initialBalance = await ethers.provider.getBalance(fundsReceiver.address);
+            const price = await nodeLicense.price(1, "");
+            const totalSupplyBeforeMint = await nodeLicense.totalSupply();
+
+            // Mint an NFT to addr1 from addr2
+            await nodeLicense.connect(addr2).mintTo(addr1.address, 1, "", { value: price });


Do we actually have coverage for minting with promoCode ?
I feel we should test minting multiple too as well as mint with promoCode, what do you think ?

Added two new test cases:

Check minting with a promo code using the mintTo function and receiving the correct funds.

Check minting multiple keys and receiving them using the mintTo Function.

…ion.

CryptITAustria

This is approved from my side. I would love for @craigbranscom to run these testcases locally and confirm everything is passing then we can merge. @XDapps Please make sure to have this documented and ping me before actually merging. Thank you.

CryptITAustria · 2024-10-02T17:07:56Z

infrastructure/smart-contracts/test/NodeLicenseTinyKeys.mjs

@@ -98,7 +98,7 @@ export function NodeLicenseTinyKeysTest(deployInfrastructure, poolConfigurations
            await xai.connect(addr1).approve(await nodeLicense.getAddress(), priceInXai);

            // Mint an NFT
-            await nodeLicense.connect(addr1).mintWithXai(1, "", false, priceInEther);
+            await nodeLicense.connect(addr1).mintWithXai(1, "", false, priceInXai);


I think the operator part is mixed up but I do remember. This was caught in the audit, we were not expecting the final price to be higher and had to reverse that check. So this makes sense to me now, thanks.

github-actions · 2024-10-10T17:07:27Z

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Jerry Hodges and others added 4 commits September 25, 2024 23:21

Added MintTo Function

b8eb22c

feat: Updated Node License Tests

389a6b8

Confirm original Node License Tests Still Pass

5092cb2

Merge branch 'fb-tiny-keys' into feat/jh/tk/add-mint-function-node-li…

28058e7

…cense

XDapps commented Sep 26, 2024

View reviewed changes

Jerry Hodges added 2 commits September 26, 2024 11:19

Comments

65a4f3a

Merge branch 'feat/jh/tk/add-mint-function-node-license' of https://g…

ac4a5f0

…ithub.com/xai-foundation/sentry into feat/jh/tk/add-mint-function-node-license

XDapps commented Sep 26, 2024

View reviewed changes

XDapps marked this pull request as ready for review September 27, 2024 12:46

XDapps requested review from CryptITAustria and craigbranscom September 27, 2024 12:46

craigbranscom reviewed Sep 27, 2024

View reviewed changes

craigbranscom self-requested a review September 30, 2024 13:18

craigbranscom approved these changes Sep 30, 2024

View reviewed changes

Merge branch 'fb-tiny-keys' into feat/jh/tk/add-mint-function-node-li…

3dfc105

…cense

CryptITAustria reviewed Oct 1, 2024

View reviewed changes

Jerry Hodges added 4 commits October 1, 2024 14:16

feat: Updated test cases to test using mintTo function with a promo code

0f6faa1

feat: Added test to test minting multiple keys using the mintTo funct…

973e0c7

…ion.

Test name grammar

1163e58

comments

a46e761

XDapps requested a review from CryptITAustria October 1, 2024 18:25

CryptITAustria approved these changes Oct 2, 2024

View reviewed changes

XDapps merged commit 76e5ea5 into fb-tiny-keys Oct 2, 2024
12 checks passed

XDapps deleted the feat/jh/tk/add-mint-function-node-license branch October 2, 2024 18:33

github-actions bot added the released label Oct 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add mintTo Function to Node License Contract. #432

Add mintTo Function to Node License Contract. #432

XDapps commented Sep 26, 2024

XDapps Sep 26, 2024

CryptITAustria Oct 1, 2024

XDapps Oct 1, 2024

CryptITAustria Oct 2, 2024

XDapps Sep 26, 2024

craigbranscom Sep 27, 2024 •

edited

Loading

XDapps Sep 27, 2024 •

edited

Loading

CryptITAustria Oct 1, 2024

XDapps Oct 1, 2024

CryptITAustria Oct 1, 2024

CryptITAustria Oct 1, 2024

XDapps Oct 1, 2024 •

edited

Loading

CryptITAustria left a comment

CryptITAustria Oct 2, 2024

github-actions bot commented Oct 10, 2024

Add mintTo Function to Node License Contract. #432

Add mintTo Function to Node License Contract. #432

Conversation

XDapps commented Sep 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

craigbranscom Sep 27, 2024 • edited Loading

Choose a reason for hiding this comment

XDapps Sep 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

XDapps Oct 1, 2024 • edited Loading

Choose a reason for hiding this comment

CryptITAustria left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Oct 10, 2024

craigbranscom Sep 27, 2024 •

edited

Loading

XDapps Sep 27, 2024 •

edited

Loading

XDapps Oct 1, 2024 •

edited

Loading