Skip to content

Audio playback repeated skipping on some audio formats and systems #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xNul opened this issue Aug 17, 2021 · 2 comments
Closed

Audio playback repeated skipping on some audio formats and systems #43

xNul opened this issue Aug 17, 2021 · 2 comments
Assignees
Labels

Comments

@xNul
Copy link
Owner

xNul commented Aug 17, 2021

The skipping happens periodically, causes skipping of anywhere from milliseconds of audio to multiple seconds. The varying nature of the bug suggests a mechanic that can be variable is at fault such as the buffering of the queueable audio sources. I suspect Drop isn't buffering the audio properly.

@xNul xNul added the bug label Aug 17, 2021
@xNul xNul self-assigned this Aug 17, 2021
@xNul
Copy link
Owner Author

xNul commented Aug 17, 2021

It turns out there are two problems that combine to create this bug. The first is Drop is not pre-buffering to fully scale with the bitrate of the audio it is processing. The second is, after running out of buffered audio, the queueable audio source pauses. It should play immediately after refilling the queue. Not accounting for this edge case caused the queueable audio source to pause for an extended period of time and the visualizer to decode audio in the meantime, not playing the audio, and resulting in the skip of multiple seconds of audio until the queueable audio source was eventually set to play once again, by an unrelated function call.

xNul added a commit that referenced this issue Aug 17, 2021
Proper playback after refilling of audio queue
xNul added a commit that referenced this issue Aug 17, 2021
Dynamic queue size for queueable audio sources. Scaling by seconds of audio.

Closes issue #43
@xNul
Copy link
Owner Author

xNul commented Aug 17, 2021

I'll have to merge this into the custom-visualizations branch eventually. Hopefully this bug is fixed for good. It was impactful enough to bring me back from a 3 year hiatus.

@xNul xNul closed this as completed Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant