Skip to content

Update gqlgen (and remove packr generate) #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StevenACoffman
Copy link
Contributor

@StevenACoffman StevenACoffman commented Feb 24, 2025

I ran a script that found every go.mod file in the repository, updated it to the latest gqlgen (using gomajor which is nice btw), ran go mod tidy, and then did a go generate ./...

Since this turns out to be non-trivial, I am leaving this PR here to track the work in breaking it up into smaller PRs.

  • - It choked on an old packr reference that appears unneeded, so I removed that, but otherwise made this draft PR without even running the tests locally just to see where things are at initially. chore: remove obsolete packr generate directive #1093
  • - update gqlgen in v2/go.mod
  • - update gqlgen in examples/federation/go.mod
  • - update gqlgen in execution/go.mod

One issue is that in 99designs/gqlgen#3507 there were some changes that where made to support @OneOf and @deprecated on input values

For instance, the codegen config and introspection changed
https://github.com/99designs/gqlgen/pull/3507/files#diff-a15c78971c63172759db98d59084361fa1aec24b37dd739d2680514021975c76R160

Signed-off-by: Steve Coffman [email protected]

@StevenACoffman
Copy link
Contributor Author

Ok, it looks like this is non-trivial, so I'm going to split this up into some smaller PRs and do this more incrementally, but I'll leave this PR around for a while to remind me of some of the files that are going to need be affected.

@devsergiy
Copy link
Member

Hi @StevenACoffman

thanks for the try
Latest gqlgen requires some changes in the resolver, as the generated code changed a bit

also, you could remove this line here

to not produce unnecessary changes

@StevenACoffman
Copy link
Contributor Author

Sure. Thanks for merging that other PR, btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants