Skip to content

Facilitate 'Ask Password' Email Resend and Alter 'Reset Password' Button Logic #7992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

AfraHussaindeen
Copy link
Contributor

@AfraHussaindeen AfraHussaindeen commented Apr 3, 2025

Purpose

Improve the user experience and administrative control within the "Ask Password" flow and in forced password reset option.

Proposed solution:

  • "Ask Password" Flow Enhancement: A "Resend" option is presented alongside the warning message related to the account lock reasoning, allowing administrators to resend the password setup email. Furthermore, a "Set Password" option (functionally equivalent to a forced password reset, but with revamped wording and only the setting password option - email sending will be excluded) is also provided, enabling administrators to directly set the user's password.

When the account locking is enabled (Ask password flow)
screencapture-localhost-9001-t-carbon-super-console-users-b094a878-bdc6-4596-929b-cb76315907f9-2025-04-09-12_30_50

When the account locking is disabled (Ask password flow)
screencapture-localhost-9001-t-carbon-super-console-users-2d908cdb-7bba-4b00-97a3-05871b5cc977-2025-04-09-12_29_25

  • Forced password reset Enhancement:

    • A "Resend" option is presented alongside the warning message related to the account lock reasoning, allowing administrators to resend
      screencapture-localhost-9001-t-carbon-super-console-users-d6858cff-4d21-4c09-a395-7c0990222918-2025-04-09-12_28_22

    • Currently, the forced password reset button is disabled when an account is locked. This logic is altered such that the "Reset Password" button is enabled when the account lock reason is [PENDING_ADMIN_FORCED_USER_PASSWORD_RESET](https://github.com/wso2-extensions/identity-governance/blob/f3724207c5e81cfed310a186a7effe32135fa06b/components/org.wso2.carbon.identity.governance/src/main/java/org/wso2/carbon/identity/governance/IdentityMgtConstants.java#L55 ) which is related to the password update scenario.

Related issues

To be merged after

TODO :

  • E2E

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@AfraHussaindeen AfraHussaindeen marked this pull request as draft April 3, 2025 01:43
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.85%. Comparing base (913fa68) to head (176e2c4).
Report is 135 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7992   +/-   ##
=======================================
  Coverage   41.85%   41.85%           
=======================================
  Files          42       42           
  Lines         939      939           
  Branches      238      238           
=======================================
  Hits          393      393           
+ Misses        546      502   -44     
- Partials        0       44   +44     
Flag Coverage Δ
@wso2is/core 41.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AfraHussaindeen AfraHussaindeen marked this pull request as ready for review April 3, 2025 08:31
@pavinduLakshan
Copy link
Member

Let's add changeset too.

@AfraHussaindeen AfraHussaindeen force-pushed the email-mobile-resend-feature branch from fb34225 to 4a24c0d Compare April 7, 2025 00:40
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants