Add: Missing ON DELETE CASCADE Constraint #13105
Conversation
BLasan
requested review from
tharindu1st,
AnuGayan,
chamilaadhi,
Arshardh,
dushaniw,
tgtshanika,
tharikaGitHub,
senthuran16,
hisanhunais,
HiranyaKavishani,
RakhithaRR,
npamudika,
HeshanSudarshana,
ashera96,
pubudu538 and
Krishanx92
as code owners
|
|
📝 WalkthroughWalkthroughThe change updates the SQL schema for Microsoft SQL Server by modifying the foreign key constraints on the Changes
Sequence Diagram(s)sequenceDiagram
participant App
participant DB as Database
App->>DB: Delete from IDN_OAUTH2_ACCESS_TOKEN or IDN_OAUTH2_AUTHORIZATION_CODE
DB-->>DB: Automatically delete related rows in IDN_OIDC_REQ_OBJECT_REFERENCE (ON DELETE CASCADE)
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
features/apimgt/org.wso2.carbon.apimgt.core.feature/src/main/resources/sql/mssql.sql (2)
1008-1009: Use explicit constraint names for maintainability
Without explicit names, SQL Server will generate system-assigned names that can vary across environments, making future drops or modifications cumbersome. Consider naming these constraints, for example:- FOREIGN KEY (TOKEN_ID) REFERENCES IDN_OAUTH2_ACCESS_TOKEN(TOKEN_ID) ON DELETE CASCADE, - FOREIGN KEY (CODE_ID) REFERENCES IDN_OAUTH2_AUTHORIZATION_CODE(CODE_ID) ON DELETE CASCADE + CONSTRAINT FK_IDN_OIDC_REQ_OBJ_REF_TOKEN_ID + FOREIGN KEY (TOKEN_ID) + REFERENCES IDN_OAUTH2_ACCESS_TOKEN(TOKEN_ID) + ON DELETE CASCADE, + CONSTRAINT FK_IDN_OIDC_REQ_OBJ_REF_CODE_ID + FOREIGN KEY (CODE_ID) + REFERENCES IDN_OAUTH2_AUTHORIZATION_CODE(CODE_ID) + ON DELETE CASCADE
1008-1009: Provide migration steps for existing databases
This DDL only affects fresh installations. To apply the same cascade behavior in production schemas already deployed, you’ll need to drop the existing foreign‐key constraints and recreate them withON DELETE CASCADE. Do you have a migration script or ALTER statements prepared for that?
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
features/apimgt/org.wso2.carbon.apimgt.core.feature/src/main/resources/sql/mssql.sql(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: build-product (2, group2)
- GitHub Check: build-product (4, group4)
- GitHub Check: build-product (1, group1)
- GitHub Check: build-product (3, group3)
- GitHub Check: build-carbon
- GitHub Check: run-benchmark-test
🔇 Additional comments (1)
features/apimgt/org.wso2.carbon.apimgt.core.feature/src/main/resources/sql/mssql.sql (1)
1008-1009: Well done: Cascading deletes for token and code references added
AddingON DELETE CASCADEto these foreign keys ensures related OIDC request references are cleaned up automatically when tokens or codes are removed, which matches the PR objective.
|
Hi, Group 4 test is failing and don't cannot retrigger the build. Hence, cannot merge Thanks & Regards, |
No description provided.