Create Unique ID of Certificate from Subject DN

[hisanhunais]

Purpose

• Create Unique ID of Certificate from Subject DN instead of Issuer DN
• Related Issue: Client-Side mTLS Fails When Using a CA-Signed Certificate as the Client Certificate api-manager#3854

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes include updates to a GitHub Actions workflow file and a modification to a utility method in the certificate management logic. The workflow file now checks out code from a different repository and branch for the product-apim component in two jobs. Separately, the logic for generating a certificate's unique identifier was changed to use the certificate's subject distinguished name instead of the issuer distinguished name, with all other processing remaining the same.

Changes

File(s)	Change Summary
.github/workflows/main.yml	Updated the actions/checkout step in build-product and run-benchmark-test jobs to use a different repo and branch.
components/apimgt/org.wso2.carbon.apimgt.impl/.../CertificateMgtUtils.java	Changed the unique identifier generation in getUniqueIdentifierOfCertificate to use SubjectDN instead of IssuerDN.

Sequence Diagram(s)

sequenceDiagram
    participant Workflow as GitHub Actions Workflow
    participant Repo as hisanhunais/product-apim (test-failure-security)
    participant Build as build-product job
    participant Benchmark as run-benchmark-test job

    Workflow->>Repo: Checkout code for build-product
    Build->>Repo: Build product
    Workflow->>Repo: Checkout code for run-benchmark-test
    Benchmark->>Repo: Run benchmark tests

Loading

sequenceDiagram
    participant Caller
    participant CertificateMgtUtils

    Caller->>CertificateMgtUtils: getUniqueIdentifierOfCertificate(certificate)
    CertificateMgtUtils->>CertificateMgtUtils: Extract serial number
    CertificateMgtUtils->>CertificateMgtUtils: Extract SubjectDN (changed from IssuerDN)
    CertificateMgtUtils->>CertificateMgtUtils: Concatenate serial number + SubjectDN
    CertificateMgtUtils-->>Caller: Return unique identifier

Loading

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 719f01e and f0d2b10.

📒 Files selected for processing (1)

• .github/workflows/main.yml (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• .github/workflows/main.yml

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: build-product (3, group3)
• GitHub Check: run-benchmark-test
• GitHub Check: build-product (4, group4)
• GitHub Check: build-product (2, group2)
• GitHub Check: build-product (1, group1)
• GitHub Check: build-carbon

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.