chore(gadm): comment gadm 4.1 logic inside getAreas #4958
Merged
+24
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtempus
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
I really like how you handled this, @willian-viana. 💪
Going to production with the code like this will let us exercise a lot of your original implementation without the 4.1 side effect.
We can't have Flagship make 4.1 area queries because there are actually 4.1 areas in the Areas microservice. So, if Flagship starts asking for them in the areas service but isn't prepared to use 4.1 logic in other places consistently, it will cause confusion.
We should introduce the 4.1 area request in a GADM 4.1 feature branch. Just not into main right now.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Since we're still on 3.6 in production. We need to remove the second 4.1 request to the RW Areas MS.
#4957