Skip to content

Add new icons for map menu #3685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 15, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/javascript/assets/icons/biodiversity.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions app/javascript/assets/icons/boundaries.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion app/javascript/assets/icons/climate.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion app/javascript/assets/icons/explore.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion app/javascript/assets/icons/forest-change.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions app/javascript/assets/icons/labels.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion app/javascript/assets/icons/land-cover.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 2 additions & 3 deletions app/javascript/assets/icons/land-use.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions app/javascript/assets/icons/roads.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -359,14 +359,16 @@ class MapControlsButtons extends PureComponent {
{this.renderBasemapsTooltip()}
</div>
)}
<div className={cx('controls-wrapper', 'map-tour-map-controls')}>
{this.renderZoomButtons()}
{this.renderShowPanelsButton()}
{this.renderShareButton()}
{this.renderPrintButton()}
{this.renderMapTourBtn()}
<div className="map-tour-map-controls">
<div className="controls-wrapper">
{this.renderZoomButtons()}
{this.renderShowPanelsButton()}
{this.renderShareButton()}
{this.renderPrintButton()}
{this.renderMapTourBtn()}
</div>
{this.renderMapPosition()}
</div>
{this.renderMapPosition()}
</Fragment>
) : (
<div className="mobile-controls-wrapper">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ class MapTour extends PureComponent {
{
target: '.map-tour-map-controls',
content:
'Access basic map tools and information: zoom in/out share, expand, zoom level, lat/long coordinates.'
'Access basic map tools: zoom out and in, expand the map, share or embed, print, and take a tour of the map. Also view zoom level and lat/long coordinates.'
},
{
target: '.map-tour-main-menu',
Expand Down
1 change: 1 addition & 0 deletions app/javascript/pages/dashboards/header/header-selectors.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export const selectLocation = state =>
(state.location && state.location.payload) || null;
export const selectLoading = state =>
state.header &&
state.countryData &&
(state.header.loading ||
state.countryData.isCountriesLoading ||
state.countryData.isRegionsLoading ||
Expand Down
3 changes: 2 additions & 1 deletion app/javascript/providers/country-data-provider/actions.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ export const setCountryLinks = createAction('setCountryLinks');
export const getCountries = createThunkAction(
'getCountries',
() => (dispatch, getState) => {
if (!getState().countryData.isCountriesLoading) {
const { countryData } = getState();
if (countryData && !countryData.isCountriesLoading) {
dispatch(setCountriesLoading(true));
axios
.all([getCountriesProvider(), getFAOCountriesProvider()])
Expand Down