Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

update bootstrap to 4.3.1 #22

Closed
bonesoul opened this issue Feb 13, 2019 · 6 comments
Closed

update bootstrap to 4.3.1 #22

bonesoul opened this issue Feb 13, 2019 · 6 comments
Labels
Request New feature or request

Comments

@bonesoul
Copy link

4.3.0 has a discovered xss vulnerability issue.

Security: Fixed an XSS vulnerability (CVE-2019-8331) in our tooltip and popover plugins by implementing a new HTML sanitizer
Fixed a small issue with our RFS (responsive font sizes) mixins

https://github.com/twbs/bootstrap/releases/v4.3.1
@bonesoul bonesoul added the Request New feature or request label Feb 13, 2019
wpsix pushed a commit that referenced this issue Feb 13, 2019
update bootstrap to latest #22
895e4fb
@wpsix wpsix closed this as completed Feb 13, 2019
@bonesoul
Copy link
Author

this update caused

Uncaught DOMException: Failed to execute 'querySelector' on 'Document'

potential fix; twbs/bootstrap#27903 (comment)

@wpsix
Copy link
Owner

wpsix commented Feb 14, 2019

@bonesoul Thanks for the report. Where did you get this error?

@bonesoul
Copy link
Author

with bootstrap 4.3.1 try clicking the top dropdown items.

@wpsix
Copy link
Owner

wpsix commented Feb 14, 2019

@bonesoul I can't reproduce this error. What is your browser?

@bonesoul
Copy link
Author

chrome 71.

i'll retry this and report back.

@bonesoul
Copy link
Author

seems it was related to my build.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bonesoul @wpsix