Skip to content

Remove "domain" as directory query param #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove "domain" as directory query param #160

wants to merge 3 commits into from

Conversation

ameesha
Copy link

@ameesha ameesha commented Jan 16, 2024

Description

We no longer filter directories by domain

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

@ameesha ameesha requested a review from a team as a code owner January 16, 2024 16:37
@ameesha ameesha requested a review from mthadley January 16, 2024 16:37
@ameesha ameesha requested review from a team, tribble, PavanKulkarni, lukemorales and blairworkos and removed request for a team January 16, 2024 16:57
PaulAsjes
PaulAsjes approved these changes Jan 18, 2024
View reviewed changes
Copy link

@PaulAsjes PaulAsjes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulAsjes PaulAsjes PaulAsjes approved these changes

@mthadley mthadley Awaiting requested review from mthadley mthadley is a code owner automatically assigned from workos/dotnet

@tribble tribble Awaiting requested review from tribble tribble was automatically assigned from workos/directory-sync

@PavanKulkarni PavanKulkarni Awaiting requested review from PavanKulkarni PavanKulkarni was automatically assigned from workos/directory-sync

@lukemorales lukemorales Awaiting requested review from lukemorales lukemorales was automatically assigned from workos/directory-sync

@blairworkos blairworkos Awaiting requested review from blairworkos blairworkos was automatically assigned from workos/directory-sync

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ameesha @PaulAsjes