Skip to content

Fix imports for ember 3.5 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix imports for ember 3.5 #25

wants to merge 2 commits into from

Conversation

gossi
Copy link

@gossi gossi commented Oct 30, 2018

The recent way of importing the installers stopped working, when we upgraded our app to ember 3.5. This fix lazy imports the installer and provide the required functionality for our tests.

That said, I haven't tests this patch against lower ember versions.

@workmanw
Copy link
Owner

@gossi Can you check to see if this issue is still necessary after #27 ? It seems to related, but not entirely. If so, can you please update the index.js?

@gossi
Copy link
Author

gossi commented Jan 10, 2019

I remember this was a hotfix after the 3.5 release of ember. We are on 0.2.1, which is working for us (maybe we did some other black magic :D @buschtoens ?).

@Turbo87 helped me to get this going. I trust him to say how this one harmonizes with his PR and whether this is needed or can be closed.

@Turbo87
Copy link
Contributor

Turbo87 commented Jan 11, 2019

#27 was just a quickfix to get ember-cli/ember-resolver#314 running again, but I think the solution here might be better in general. Ideally, we could indeed concat everything in the right order using Broccoli, but with the current hooks, that's more complicated than this proposed solution.

@workmanw
Copy link
Owner

The recent way of importing the installers stopped working...

I read that as this addon no longer works at all with ember 3.5 and that's why I was trying to determine if @Turbo87's fix also resolved this issue.

@stefanpenner
Copy link
Collaborator

I am upstreaming these assertions into ember-qunit

I will review this PR, and try and incorporate appropriate changes upstream.

When all this lands, my plan is to deprecate this library entirely in-favor of it's assertions simply being officially supported: #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants