Skip to content

[FE] 아이콘 적용 버그 문제 해결 #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2025
Merged

[FE] 아이콘 적용 버그 문제 해결 #942

merged 2 commits into from
Jan 15, 2025

Conversation

Todari
Copy link
Contributor

@Todari Todari commented Jan 15, 2025

issue

구현 사항

  1. Icon Component size가 제대로 적용되지 않았던 문제 해결
  2. 다음 task에서 필요한 setting Component 구현

중점적으로 리뷰받고 싶은 부분(선택)

어떤 부분을 중점으로 리뷰했으면 좋겠는지 작성해주세요.

논의하고 싶은 부분(선택)

논의하고 싶은 부분이 있다면 작성해주세요.

🫡 참고사항

@Todari Todari added this to the v3.1.1 milestone Jan 15, 2025
@Todari Todari requested review from pakxe, soi-ha and jinhokim98 January 15, 2025 08:26
@Todari Todari self-assigned this Jan 15, 2025
Copy link
Contributor

@pakxe pakxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿쓰

Copy link
Contributor

@jinhokim98 jinhokim98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

Copy link
Contributor

@soi-ha soi-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

믿음의 어뿌로브

Copy link

@jinhokim98 jinhokim98 merged commit 152f35b into fe-dev Jan 15, 2025
2 checks passed
@jinhokim98 jinhokim98 deleted the feature/#941 branch January 15, 2025 08:29
@jinhokim98 jinhokim98 mentioned this pull request Jan 15, 2025
jinhokim98 pushed a commit that referenced this pull request Jan 15, 2025
* fix: 잘못 적용된 Icon 수정

* feat: IconSetting component 구현
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants