Add batch upsert/delete actions and reducer for shipping rates/times to communicate with batch APIs #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomalec
approved these changes
Apr 1, 2021
Comment on lines
+32
to
+43
| const getNextStateForShipping = ( state ) => { | ||
| return { | ||
| ...state, | ||
| mc: { | ||
| ...state.mc, | ||
| shipping: { | ||
| ...state.mc.shipping, | ||
| }, | ||
| }, | ||
| }; | ||
| }; | ||
|
|
There was a problem hiding this comment.
❔ Can we use that in RECEIVE_ as well, to solve #270, or would you prefer it to be a separate PR?
There was a problem hiding this comment.
The getNextStateForShipping function was an interim solution to keep the problem from spreading for the time being. Even so, I think we can apply them on RECEIVE_ first, and it would be good to open a separate PR next week to deal with it quickly. Because I will start AFK tomorrow. 😆 🎉 (And please feel free if anyone wants to deal with that 🙏 👍 )
This was referenced Apr 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR implemented a part of issue #358 and depends on #410. It needs to change the shared data lib that corresponding to others' work, so it's presented separately to facilitate collaboration.
Detailed test instructions:
/wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fsetup-mc❗ Please note that the migrations of the consuming side aren't included in this PR, so the UI may still appear bouncy problems and too many connection errors.