Display notification badge in the admin menu when there are recommendations #3001
+267
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog: update
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/GOOWOO-172-pmax-assets-improvements #3001 +/- ##
================================================================================
- Coverage 66.4% 66.0% -0.4%
- Complexity 0 4849 +4849
================================================================================
Files 335 835 +500
Lines 5194 25894 +20700
Branches 1269 1291 +22
================================================================================
+ Hits 3449 17093 +13644
- Misses 1592 8647 +7055
- Partials 153 154 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
src/Menu/NotificationManager.php
Outdated
| ); | ||
|
|
||
| $page_controller_pages = PageController::get_instance()->get_pages(); | ||
| $marketing_menu_slug = 'woocommerce-marketing'; |
There was a problem hiding this comment.
Suggested change
| $marketing_menu_slug = 'woocommerce-marketing'; | |
| $marketing_menu_slug = Dashboard::MARKETING_MENU_SLUG; |
src/Menu/NotificationManager.php
Outdated
|
|
||
| $marketing_menu_pages = array_filter( | ||
| $page_controller_pages, | ||
| function ( $page ) use ( $marketing_menu_slug ) { |
There was a problem hiding this comment.
Suggested change
| function ( $page ) use ( $marketing_menu_slug ) { | |
| static function ( $page ) use ( $marketing_menu_slug ) { |
Use static that improve performance.
src/Menu/NotificationManager.php
Outdated
| const subMenu = document.querySelector('[href="admin.php?page=wc-admin&path=%2Fgoogle%2Fdashboard"]'); | ||
|
|
||
| if (subMenu && !subMenu.contains(badge)) { | ||
| // Ensure there is white space betweem the bade and menu title for visual consistency. |
There was a problem hiding this comment.
Suggested change
| // Ensure there is white space betweem the bade and menu title for visual consistency. | |
| // Ensure there is white space between the badge and menu title for visual consistency. |
src/Menu/NotificationManager.php
Outdated
| subMenu.textContent.trimEnd(); | ||
| subMenu.textContent += ' '; | ||
|
|
||
| // Move the bade to the correct location. |
There was a problem hiding this comment.
Suggested change
| // Move the bade to the correct location. | |
| // Move the badge to the correct location. |
src/Menu/NotificationManager.php
Outdated
| } | ||
| } else { | ||
| if (topMenu && !topMenu.contains(badge)) { | ||
| // Ensure there is white space betweem the bade and menu title for visual consistency. |
There was a problem hiding this comment.
Suggested change
| // Ensure there is white space betweem the bade and menu title for visual consistency. | |
| // Ensure there is white space between the badge and menu title for visual consistency. |
src/Menu/NotificationManager.php
Outdated
| topMenu.textContent.trimEnd(); | ||
| topMenu.textContent += ' '; | ||
|
|
||
| // Move the bade to the correct location. |
There was a problem hiding this comment.
Suggested change
| // Move the bade to the correct location. | |
| // Move the badge to the correct location. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes https://linear.app/a8c/issue/GOOWOO-182/display-notification-badge-in-the-admin-menu-when-there-are
google_for_woocommerce_admin_menu_notification_countfilter.Screenshots:
Marketing menu with notification badge.
Marketing sub-menu with notification badge.
Detailed test instructions:
google_for_woocommerce_admin_menu_notification_countfilter returns0. This is the default behaviour.add_filter('google_for_woocommerce_admin_menu_notification_count', function() { return 1; }7. When the Marketing menu is collapsed, the badge appears on the Marketing menu item.
8. When the Marketing menu is expanded, the badge appears on the Google for WooCommerce sub menu item.
Additional details:
Changelog entry