Do not render experience rating banner if Ads account is disconnected. #3000
+203
−180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes https://linear.app/a8c/issue/GOOWOO-210/api-errors-triggered-from-app-ratings-notice-when-no-ads-account-is
Replace this with a good description of your changes & reasoning.
useProductsReport
hook is used in other parts of the app, so I avoided adding a check for a connected Ads account directly within the hook to prevent potential regressions.Screenshots:
Detailed test instructions:
/wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fsettings
/wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fdashboard
)/wc/gla/ads/reports/products
endpoint.Additional details:
Changelog entry
Fix – Do not render experience rating banner if Ads account is disconnected.