[GOOWOO-180] Enhance plugin architecture to support YouTube Videos

[ankitrox]

Changes proposed in this Pull Request:

Closes https://linear.app/a8c/issue/GOOWOO-180/enhance-plugin-architecture-to-support-youtube-videos

Replace this with a good description of your changes & reasoning.

Screenshots:

Detailed test instructions

1. Create a campaign in Dashboard by clicking Add campaign button. You can also create a campaign directly in Google ads account for this testing.

2. Add the asset using Create button in Google ads dashboard. Create a video asset by following all the given guidelines.

3. Create an asset group and add that video asset to the asset group. Note that it takes some time ~20 minutes to get that video eligible in the asset group.

4. Import the postman collection added in slack pinned folder. Adjust the environment variables for GLA environment.

5. Use GET:ads-asset-groups collection to retrieve the assets for that asset groups, you should be able to see the youtube_video there.

6. Use All Endpoints collection and ensure that for wc/gla/ads/campaigns/asset-group/{id} endpoint, for field_type argument, youtube_video is available in schema.

Additional details:

Changelog entry

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.2%. Comparing base (39781c4) to head (83d9cbe).
Report is 90 commits behind head on feature/GOOWOO-172-pmax-assets-improvements.

Additional details and impacted files

@@                               Coverage Diff                               @@
##             feature/GOOWOO-172-pmax-assets-improvements   #2986     +/-   ##
===============================================================================
- Coverage                                           66.2%   66.2%   -0.1%     
- Complexity                                          4814    4823      +9     
===============================================================================
  Files                                                490     491      +1     
  Lines                                              20446   20522     +76     
===============================================================================
+ Hits                                               13542   13579     +37     
- Misses                                              6904    6943     +39     

Flag	Coverage Δ
php-unit-tests	66.2% <100.0%> (-0.1%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/API/Google/AdsAsset.php	95.5% <100.0%> (+0.3%)	⬆️
src/API/Google/AdsAssetGroupAsset.php	85.5% <100.0%> (+0.7%)	⬆️
src/API/Google/Query/AdsAssetGroupAssetQuery.php	100.0% <100.0%> (ø)
.../API/Site/Controllers/Ads/AssetGroupController.php	100.0% <100.0%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[joemcgill]

This looks like it will do the trick, @ankitrox. Approving with one suggestion.

[joemcgill]

Rather than adding this column to both places where the AdsAssetGroupAssetQuery is used, consider adding it as a default column, here:

google-listings-and-ads/src/API/Google/Query/AdsAssetGroupAssetQuery.php

Line 20 in dcb27c5

$this->columns( [ 'asset.id', 'asset.name', 'asset.type', 'asset.text_asset.text', 'asset.image_asset.full_size.url', 'asset.call_to_action_asset.call_to_action', 'asset_group_asset.field_type' ] );

[ankitrox]

Thank you @joemcgill , this looks like a proper place to add this new column. Made that change as per suggestion.

[joemcgill]

Same as above

[joemcgill]

Thanks, @ankitrox