-
Notifications
You must be signed in to change notification settings - Fork 22
Block Shipping, Products and Coupons when Sync Push is disabled #2810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2810 +/- ##
===========================================
- Coverage 67.3% 67.2% -0.1%
- Complexity 4709 4721 +12
===========================================
Files 481 481
Lines 19725 19770 +45
===========================================
+ Hits 13267 13281 +14
- Misses 6458 6489 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @puntope for working on these changes.
As explained in the comments, I think we should follow some of the simple logic as is done for Shipping. As it is right now a product/coupon status will still be changed to pending sync even if push is disabled, we should not allow any changes if it's disabled.
627a0dd
to
c334775
Compare
Update SyncerHooks tests to mock the is_enabled_for_datatype method that was added to prevent sync jobs when PUSH is disabled. The tests now properly expect sync operations to be scheduled or not based on the merchant center status. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
This PR will be delivered as part of the combined effort in #2981, which includes both the sync push controls and WC REST API settings integration. Closing this individual PR in favor of the combined approach. |
Changes proposed in this Pull Request:
Block Merchant Center Sync in case the Sync is disabled for the datatype
Detailed test instructions:
gla/jobs/update_products/process_item
. Run itgla/jobs/update_products/process_item
. Run itgla/jobs/update_coupon/process_item
. Run itgla/jobs/update_coupon/process_item
. Run itgla/jobs/update_shipping_settings/process_item
Additional details:
PT: pcTzPl-2yG-p2
Changelog entry