Skip to content

Remove an unused hook useCallbackOnceEffect #1995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

eason9487
Copy link
Member

Changes proposed in this Pull Request:

While working on #1994 and recap relevant changes, found this hook has not been in use for a long time. This hook should be removed along with 20e758f in #1616 but I missed it.

This PR removes it from the codebase.

Detailed test instructions:

Search the codebase to check if the hook is actually not in use.

Changelog entry

@eason9487 eason9487 requested a review from a team June 21, 2023 10:17
@eason9487 eason9487 self-assigned this Jun 21, 2023
@github-actions github-actions bot added the changelog: dev Developer-facing only change. label Jun 21, 2023
Copy link
Contributor

@puntope puntope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

I cannot find any occurrences in the codebase using useCallbackOnceEffect

@eason9487 eason9487 merged commit a9d35a3 into develop Jun 22, 2023
@eason9487 eason9487 deleted the dev/remove-unused-hook branch June 22, 2023 02:23
@eason9487 eason9487 mentioned this pull request Jul 11, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants