Free Listings + Paid Ads: Fix a compatibility issue with the Form component in WC 6.9 #1672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the exposed interfaces of Form component
github-actions
bot
added
changelog: fix
eason9487
added
changelog: fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
It relates to #1610
The
<Form ref={ formRef }>use was added in 93249e6 (#1616) and was the only one use case. However, WC 6.9 changes the exposed interfaces ofFormcomponent, so it needs another way to do the same logic.This PR fixes the exception in the target audience setup of onboarding flow.
Screenshots:
Kapture.2022-09-14.at.18.59.54.mp4
Detailed test instructions:
Changelog entry