Skip to content

Add name and domain to account API to facilitate UX improvements #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2021

Conversation

JPry
Copy link
Contributor

@JPry JPry commented Nov 12, 2021

Changes proposed in this Pull Request:

This sets up the plugin to handle the updated API responses from the connect server. The connect server will start including name and domain information for each linked Merchant Center account.

The main changes here are to our REST API schema, and also to the Google API class. The API class renames Automattic\WooCommerce\GoogleListingsAndAds\API\Google\Proxy::get_merchant_ids() to Automattic\WooCommerce\GoogleListingsAndAds\API\Google\Proxy::get_merchant_accounts(). I've also created a new version of the get_merchant_ids() method, in case it is being used by any 3rd parties.

Changelog entry

Update – Add support for retrieving the name and domain from the Google API

@JPry JPry requested a review from a team November 12, 2021 23:52
@JPry JPry self-assigned this Nov 12, 2021
@ecgan ecgan mentioned this pull request Nov 14, 2021
11 tasks
Copy link
Contributor

@ianlin ianlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally, verified the /wp-json/wc/gla/mc/accounts API returns name and domain fields in the response.

@JPry JPry force-pushed the feature/account_name_api branch from 0602b9d to 4103d85 Compare November 15, 2021 17:40
@JPry
Copy link
Contributor Author

JPry commented Nov 15, 2021

Just a note that these changes depend on https://github.com/Automattic/woocommerce-connect-server/pull/1844 being merged/deployed to the vip-go server.

@JPry JPry merged commit 43146b6 into develop Nov 15, 2021
@JPry JPry deleted the feature/account_name_api branch November 15, 2021 17:44
@findingsimple findingsimple added this to the 1.7 milestone Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants