Add heirarchical makefiles, update .gitignores, fix missing init in rsa benchmark #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble initialization in benchmark
There was a problem hiding this comment.
Pull Request Overview
Streamlines the build process by introducing hierarchical Makefiles, updating ignore rules, and fixing an uninitialized variable in the RSA benchmark.
- Added
nvm_metadata.txtto.gitignorefor whnvmtool. - Created subdirectory Makefiles for
tools/testcertgen,tools,examples, and a top-levelMakefile. - Initialized
benchStartRetinwh_bench_mod_rsa.cto prevent use of an uninitialized variable.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/whnvmtool/.gitignore | Ignoring new metadata file |
| tools/testcertgen/Makefile | Added build target and placeholder clean target |
| tools/Makefile | Entry point for building tools subdirectories |
| examples/Makefile | Entry point for building example subdirectories |
| benchmark/bench_modules/wh_bench_mod_rsa.c | Initialized benchStartRet to 0 |
| Makefile | Top-level orchestration for test, benchmark, tools, examples |
bigbrett
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifications and cleanups.