Skip to content

fix: injected standard prefixes reference wikidata #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 28, 2024
Merged

fix: injected standard prefixes reference wikidata #804

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11fb8b2
fix: use WIKIBASE_CONCEPT_URI for default prefixes
rti Nov 8, 2024
39795c6
fix: keep wd: et al. prefixes for wikidata
rti Nov 13, 2024
79b7c61
Merge branch 'main' into fix-wdqs-std-prefixes-use-concept-uri
rti Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion build/wdqs/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,24 @@ done

set -eu

export BLAZEGRAPH_OPTS="${BLAZEGRAPH_EXTRA_OPTS} -DwikibaseHost=${WIKIBASE_HOST}"
# Options provided to WDQS (blazegraph) when running as query service instance
#
# Note: We MUST not provide -DwikibaseHost=${WIKIBASE_HOST} here, otherwise
# WDQS would re-use the wd: et al. prefixes for the local wikibase instance.
# This is unintended, especially in the context of federation. wd: prefixes
# should remain in place for referencing wikidata. The local instance should
# choose its own prefixes, as described here:
# https://www.mediawiki.org/wiki/Wikibase/Wikibase.cloud/First_steps#View_your_data_using_the_Query_Service
# Some further thoughts on prefixes: https://phabricator.wikimedia.org/T335448
#
# In other words, WDQS does not know about the hostname of the wiki it gets
# its data from. Is is solely the task of the updater to feed data from the
# wiki into the WDQS instance.
export BLAZEGRAPH_OPTS="${BLAZEGRAPH_EXTRA_OPTS}"

# Options provided when running as wdqs-updater
#
# Here we provide -DwikibaseHost to reference the wiki to poll updates from.
export UPDATER_OPTS="-DwikibaseHost=${WIKIBASE_HOST} -DwikibaseMaxDaysBack=${WIKIBASE_MAX_DAYS_BACK}"

envsubst < /templates/mwservices.json > /wdqs/mwservices.json
Expand Down