FIx DST issue #189
Merged
FIx DST issue #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 2, 2025
wmalgadey
pushed a commit
that referenced
this pull request
Apr 3, 2025
arjanvlek
added a commit
to arjanvlek/libtado
that referenced
this pull request
Apr 3, 2025
For long-running clients (i.e. where the `Tado` object is not constructed each time the API is called), there appears to be an issue with the refresh tokens and DST. This was first reported by Tado in PyTado, see wmalgadey/PyTado#188 A fix has since been made, mainly for use with HA. Since the Oauth code is mostly taken over from PyTado, applied the same changes (see wmalgadey/PyTado#189) to make our codebase compliant as well.
This was referenced Apr 3, 2025
germainlefebvre4
pushed a commit
to germainlefebvre4/libtado
that referenced
this pull request
Apr 7, 2025
For long-running clients (i.e. where the `Tado` object is not constructed each time the API is called), there appears to be an issue with the refresh tokens and DST. This was first reported by Tado in PyTado, see wmalgadey/PyTado#188 A fix has since been made, mainly for use with HA. Since the Oauth code is mostly taken over from PyTado, applied the same changes (see wmalgadey/PyTado#189) to make our codebase compliant as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide a clear and concise description of the changes you are proposing.
Fixes the Daylight Saving Time issue reported by Tado.
Related Issues
Link any related issues that this pull request resolves or is associated with:
Type of Changes
Mark the type of changes included in this pull request:
Checklist
Additional Notes
Add any additional comments, screenshots, or context for the reviewer(s).
Thank you for your contribution to PyTado! 🎉