refacto: [CalendarHeader, ExpandableCalendar] replace defaultProps with ES6 default parameters #2480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h default parameters on components props
david-mi
changed the title
david-mi
changed the title
|
Would be nice to merge this to remove the console error; and to be up to date. |
oogunjob
approved these changes
Oct 21, 2024
fzzio
approved these changes
Nov 2, 2024
|
can we get this reviewed? |
| @@ -621,15 +621,4 @@ const ExpandableCalendar = (props: ExpandableCalendarProps) => { | |||
| export default ExpandableCalendar; | |||
|
|
|||
| ExpandableCalendar.displayName = 'ExpandableCalendar'; | |||
| ExpandableCalendar.defaultProps = { | |||
There was a problem hiding this comment.
should we fill in the rest of these as well in src/calendar/header/index.tsx? I think firstDay is the only one that's enumerated above so we maybe replace it withfirstDay = 0.
Are the other props not used or why are they here?
There was a problem hiding this comment.
Oh looks like the other ones are ExpandableCalendar props. I think we're also missing arrowsHitSlop in CalendarHeader?
Dallas62
approved these changes
Mar 11, 2025
|
Ping @nitzanyiz It includes some fix for new RN versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
As we can read see in this article : React 19 RC Upgrade Guide#removed-deprecated-react-apis
defaultPropsare being deprecated and won't be supported anymore with functional components in React 19Suggested Fix
Simply replace concerned functional components (
ExpandableCalendarandCalendarHeader) default props from with ES6 default parameters (some default parameters were already applied this way butdefaultPropsusage was remaining