Skip to content

WIP] Update react native 0.77.2 #4758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 21, 2025

Conversation

mauricedoepke
Copy link
Contributor

While working on my screenshot PR I wanted to also somewhat test the ios build
If found out, that apple just broke react native < 0.77, see:
https://expo.dev/changelog/xcode-16-3-patches

For this reason I tried upgrading the demo/example apps to react native 0.77.2. I did not check everything yet. But so far it seems that most this is mostly working.

I think there might be very few tests broken. Bot not many. Some of your tests seem to fetch data from private endpoints which seems to be working from your ci only. Maybe you can let the tests run on this if you are interested in updating the rn version.

@gosha212 gosha212 changed the title WIP] Update react native 0.72.2 WIP] Update react native 0.77.2 Apr 14, 2025
@gosha212
Copy link
Contributor

gosha212 commented Apr 14, 2025

@mauricedoepke Thanks for the collaboration. This change is in our roadmap for sure. Can you elaborate which tests you failed to run locally? It should work on every machine without any issues.
I've approved the CI run. Lets see if it fails or not.

@mauricedoepke
Copy link
Contributor Author

@gosha212

I do not remember all:
but on android it was:

  • "should handle tap during storage stress" this one sounds like it might be flaky and very dependent on enrionment conditions

and on ios:
I think more or less all the "pilot" tests. But if I remember correctly this failed because they tried to fetch stuff frome some wix server which failed for me probably due to authorization.

But I did not observe naything major.

Copy link
Contributor

@gosha212 gosha212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did amazing job!
Please add the configurations for RN 76 back in order to insure that it still works. I will remove it after merging in order to save us some build time.

Copy link
Contributor

@gosha212 gosha212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the build is not working for ios 73

@mauricedoepke
Copy link
Contributor Author

looks like the build is not working for ios 73

Sorry, totally forgot, that for such a project background compatibility is super important. I totally forgot that the newly added code might break that. I can check this out on the weekend.

@gosha212
Copy link
Contributor

@mauricedoepke I've taken this PR in my hands in order to speed up the process. I will share the result with you.
You were right about the pilot tests. They are using a local server. Thanks for your help

@mauricedoepke
Copy link
Contributor Author

@gosha212 thanks a lot for doing so

@gosha212 gosha212 merged commit a704534 into wix:master Apr 21, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants