-
Notifications
You must be signed in to change notification settings - Fork 1.9k
WIP] Update react native 0.77.2 #4758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP] Update react native 0.77.2 #4758
Conversation
@mauricedoepke Thanks for the collaboration. This change is in our roadmap for sure. Can you elaborate which tests you failed to run locally? It should work on every machine without any issues. |
I do not remember all:
and on ios: But I did not observe naything major. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did amazing job!
Please add the configurations for RN 76 back in order to insure that it still works. I will remove it after merging in order to save us some build time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like the build is not working for ios 73
Sorry, totally forgot, that for such a project background compatibility is super important. I totally forgot that the newly added code might break that. I can check this out on the weekend. |
@mauricedoepke I've taken this PR in my hands in order to speed up the process. I will share the result with you. |
@gosha212 thanks a lot for doing so |
While working on my screenshot PR I wanted to also somewhat test the ios build
If found out, that apple just broke react native < 0.77, see:
https://expo.dev/changelog/xcode-16-3-patches
For this reason I tried upgrading the demo/example apps to react native 0.77.2. I did not check everything yet. But so far it seems that most this is mostly working.
I think there might be very few tests broken. Bot not many. Some of your tests seem to fetch data from private endpoints which seems to be working from your ci only. Maybe you can let the tests run on this if you are interested in updating the rn version.