Skip to content

Revamped RSS instructions for content collections #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jan 19, 2023
Merged

Conversation

bholmesdev
Copy link
Contributor

@bholmesdev bholmesdev commented Jan 17, 2023

What kind of changes does this PR include?

  • New or updated content

Description

  • Updates for [RSS] Get ready for content collections astro#5851
  • Change import.meta.env.SITE to new context.site
  • Update leading example to use content collections
  • Add new "using content collections" section to "Generating items"
  • Update glob import instructions to recommend the pagesGlobToRssItems() function
  • Update "including full post content" with content collections instructions. The markdown-it recommendation may change once we support an html output for content collections!

@netlify
Copy link

netlify bot commented Jan 17, 2023

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit bbac665
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/63c967c58b2a3200086943a8
😎 Deploy Preview https://deploy-preview-2401--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Better RSS docs! 🥳

Thanks for making these so easy to read and follow, Ben! I have some suggestions for tightening up and orienting these to be a bit more usage-based for you to consider, but these should be quick to wrap up!

Co-authored-by: Sarah Rainsberger <[email protected]>
@sarah11918 sarah11918 added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label Jan 19, 2023
@bholmesdev bholmesdev requested a review from sarah11918 January 19, 2023 15:41
bholmesdev and others added 2 commits January 19, 2023 10:54
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 !

You'll need to re-we in the README itself, too, but they're both good to go!

@bholmesdev bholmesdev merged commit d373149 into main Jan 19, 2023
@bholmesdev bholmesdev deleted the feat/new-rss branch January 19, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants