Skip to content

Refactor ViteConfigWithSSR type #4952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Refactor ViteConfigWithSSR type #4952

merged 1 commit into from
Oct 3, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 3, 2022

Changes

Vite 3 stabilizes the .ssr property and is exposed from the types, so this type isn't needed anymore

Testing

Existing tests should pass.

Docs

N/A

@bluwy bluwy requested a review from a team as a code owner October 3, 2022 10:01
@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2022

🦋 Changeset detected

Latest commit: d279ff0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 3, 2022
@bluwy bluwy merged commit 5bcd76e into main Oct 3, 2022
@bluwy bluwy deleted the refactor-vite-config-ssr branch October 3, 2022 14:54
@astrobot-houston astrobot-houston mentioned this pull request Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants