-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(i18n): incorrect validation #13552
Conversation
🦋 Changeset detectedLatest commit: ceff5f2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
astro
@astrojs/cloudflare
@astrojs/netlify
@astrojs/node
@astrojs/vercel
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick response @ematipico!
CodSpeed Performance ReportMerging #13552 will not alter performanceComparing Summary
|
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation. Makes sense. Left one more thing to consider in case we’d risk breaking things for anyone.
Changes
Closes #13551
After 5.6.0, where we changed how we validate the astro configuration, we found out that Astro was validating incorrect values for `i18n.routing.
This PR fixes the values.
Testing
Updated tests and error message.
Docs
cc @delucis and @HiDeoo