Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): incorrect validation #13552

Merged
merged 7 commits into from
Apr 4, 2025
Merged

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Apr 3, 2025

Changes

Closes #13551

After 5.6.0, where we changed how we validate the astro configuration, we found out that Astro was validating incorrect values for `i18n.routing.

This PR fixes the values.

Testing

Updated tests and error message.

Docs

cc @delucis and @HiDeoo

Copy link

changeset-bot bot commented Apr 3, 2025

🦋 Changeset detected

Latest commit: ceff5f2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Apr 3, 2025
@ematipico ematipico added the pr preview This PR has a preview release label Apr 3, 2025
Copy link

pkg-pr-new bot commented Apr 3, 2025

astro

npm i https://pkg.pr.new/astro@13552

@astrojs/cloudflare

npm i https://pkg.pr.new/@astrojs/cloudflare@13552

@astrojs/netlify

npm i https://pkg.pr.new/@astrojs/netlify@13552

@astrojs/node

npm i https://pkg.pr.new/@astrojs/node@13552

@astrojs/vercel

npm i https://pkg.pr.new/@astrojs/vercel@13552

commit: 8c1bc76

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick response @ematipico!

Copy link

codspeed-hq bot commented Apr 3, 2025

CodSpeed Performance Report

Merging #13552 will not alter performance

Comparing fix/incorrect-i18n-validation (ceff5f2) with main (3323f5c)

Summary

✅ 6 untouched benchmarks

@ematipico ematipico requested a review from delucis April 3, 2025 15:53
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. Makes sense. Left one more thing to consider in case we’d risk breaking things for anyone.

@ematipico ematipico merged commit 9cd0fd4 into main Apr 4, 2025
37 of 40 checks passed
@ematipico ematipico deleted the fix/incorrect-i18n-validation branch April 4, 2025 07:47
@astrobot-houston astrobot-houston mentioned this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr preview This PR has a preview release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration Error with i18n.routing.redirectToDefaultLocale in Starlight
2 participants