Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update vite to latest version #13526

Merged
merged 3 commits into from
Mar 31, 2025
Merged

fix: update vite to latest version #13526

merged 3 commits into from
Mar 31, 2025

Conversation

jsparkdev
Copy link
Member

@jsparkdev jsparkdev commented Mar 31, 2025 •
edited
Loading

Changes

Update vite to 6.2.4 to resolve GHSA-4r4m-qw57-chr8

Testing

should pass

Docs

N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 4aea000

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: react Related to React (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Mar 31, 2025
@jsparkdev jsparkdev marked this pull request as draft March 31, 2025 13:30
@jsparkdev jsparkdev marked this pull request as ready for review March 31, 2025 13:34
@ematipico
Copy link
Member

Another one?? Oh man 😄

@ematipico
Copy link
Member

@jsparkdev can you run pnpm dedupe from the root of the repository and commit any changes to the lock file? That should fix the CI failure

@jsparkdev
Copy link
Member Author

@ematipico

Thanks for your help!

I didn't know why CI kept failing lol.

ematipico
ematipico approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Feel free to merge once the CI passes

@jsparkdev jsparkdev merged commit ff9d69e into withastro:main Mar 31, 2025
15 checks passed
@jsparkdev jsparkdev deleted the vite-update branch March 31, 2025 14:18
@astrobot-houston astrobot-houston mentioned this pull request Mar 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsparkdev @ematipico