feat: improve rolldown compatibility #13519
Conversation
🦋 Changeset detectedLatest commit: 5bf450a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
CodSpeed Performance ReportMerging #13519 will not alter performanceComparing Summary
|
|
Can you please breakdown the changes for us reviewers? I don't know what the changes are for, and what I'm reviewing |
| @@ -151,7 +154,7 @@ export default function assets({ settings }: { settings: AstroSettings }): vite. | |||
| }, | |||
| // In build, rewrite paths to ESM imported images in code to their final location | |||
| async renderChunk(code) { | |||
| const assetUrlRE = /__ASTRO_ASSET_IMAGE__([\w$]{8})__(?:_(.*?)__)?/g; | |||
| const assetUrlRE = /__ASTRO_ASSET_IMAGE__([\w$]+)__(?:_(.*?)__)?/g; | |||
There was a problem hiding this comment.
In rolldown hashes are not exactly 8 long
| @@ -57,6 +57,9 @@ function getNonPrerenderOnlyChunks(bundle: Rollup.OutputBundle, internals: Build | |||
|
|
|||
| nonPrerenderOnlyEntryChunks.add(chunk); | |||
| } | |||
| if (chunk.type === 'chunk' && chunk.isDynamicEntry) { | |||
There was a problem hiding this comment.
This would be a bug in Astro according to the patch file
There was a problem hiding this comment.
Thank you @florian-lefebvre. I would add a changelog so we can track the changes, in case there's some unexpected regression to our users.
Also, I would appreciate if we left comments in the places where we now return objects. We return strings on most of our plugins, however only the asset ones require an object. We should keep track of the change with a comment, so maintainers aren't going to refactor it.
Changes
loadto return an object instead of a string so it's easier to adopt Rolldown module typesTesting
Should pass
Docs
N/A. No changeset since it's a refactor