Skip to content

test: make tailwind test more stable #12732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

ematipico
Copy link
Member

Changes

The tailwind test suite became unstable, this PR should help with that.

Testing

All CI should be green

Docs

N/A

Copy link

changeset-bot bot commented Dec 13, 2024

⚠️ No Changeset found

Latest commit: b4f4c04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Dec 13, 2024
Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 other tailwind config where we should apply this change I think https://github.com/search?q=repo%3Awithastro%2Fastro%20__dirname&type=code

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Dec 13, 2024
@florian-lefebvre
Copy link
Member

Ha actually maybe it's not needed for the last 2 because they use cjs and require?

@ematipico ematipico force-pushed the chore/fix-regression-tailwind branch from a7eebf7 to b4f4c04 Compare December 13, 2024 14:37
@github-actions github-actions bot removed the pkg: astro Related to the core `astro` package (scope) label Dec 13, 2024
@ematipico ematipico merged commit 901c21f into main Dec 13, 2024
18 checks passed
@ematipico ematipico deleted the chore/fix-regression-tailwind branch December 13, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants