Skip to content

chore: Refactor page object implementation [WPB-18373] #19172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 25, 2025

Conversation

iskvortsov
Copy link
Contributor

@iskvortsov iskvortsov commented Jun 24, 2025

TaskWPB-18373 [Web] Refactor page object implementation

Description

Added PageManager to avoid come duplication and allow better page object handling

https://wearezeta.atlassian.net/browse/WPB-18373

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@iskvortsov iskvortsov requested review from araneforseti and removed request for a team and otto-the-bot June 24, 2025 15:29
Copy link
Contributor

github-actions bot commented Jun 25, 2025

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 1
  • Failed: 2
  • Skipped: 0
  • 🔁 Flaky: 0
  • 📊 Total: 3
  • Total Runtime: 251.3s (~ 4 min 11 sec)

Failures

❌ Team owner adds whole team to an all team chat (tags: TC-8631, crit-flow)

Location: criticalFlow.spec.ts:30
Duration: 30812ms

Errors:

Test timeout of 30000ms exceeded.
Error: locator.click: Test timeout of 30000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name=\'primary-modals-container\'][aria-label=\'Consent to share user data\']').locator('[data-uie-name=\'do-secondary\']')


   at pages/dataShareConsent.modal.ts:59

  57 |   async clickDecline() {
  58 |     await this.declineButton.isVisible();
> 59 |     await this.declineButton.click();
     |                              ^
  60 |   }
  61 |
  62 |   async clickConfirm() {
    at DataShareConsentModal.clickDecline (/home/runner/work/wire-webapp/wire-webapp/test/e2e_tests/pages/dataShareConsent.modal.ts:59:30)
    at /home/runner/work/wire-webapp/wire-webapp/test/e2e_tests/criticalFlow.spec.ts:57:5
    at /home/runner/work/wire-webapp/wire-webapp/test/e2e_tests/criticalFlow.spec.ts:52:3
❌ Personal Account Lifecycle (tags: TC-8638, crit-flow)

Location: criticalFlow.spec.ts:158
Duration: 716ms

Errors:

AxiosError: Request failed with status code 429

   at backend/authRepository.e2e.ts:28

  26 | export class AuthRepositoryE2E extends BackendClientE2E {
  27 |   public async registerUser(user: User, invitationCode?: string): Promise<AxiosResponse> {
> 28 |     const response = await this.axiosInstance.post('register', {
     |                      ^
  29 |       password: user.password,
  30 |       name: `${user.firstName} ${user.lastName}`,
  31 |       email: user.email,
    at settle (/home/runner/work/wire-webapp/wire-webapp/node_modules/axios/lib/core/settle.js:19:12)
    at IncomingMessage.handleStreamEnd (/home/runner/work/wire-webapp/wire-webapp/node_modules/axios/lib/adapters/http.js:599:11)
    at Axios.request (/home/runner/work/wire-webapp/wire-webapp/node_modules/axios/lib/core/Axios.js:45:41)
    at AuthRepositoryE2E.registerUser (/home/runner/work/wire-webapp/wire-webapp/test/e2e_tests/backend/authRepository.e2e.ts:28:22)
    at ApiManagerE2E.createPersonalUser (/home/runner/work/wire-webapp/wire-webapp/test/e2e_tests/backend/apiManager.e2e.ts:78:30)
    at /home/runner/work/wire-webapp/wire-webapp/test/e2e_tests/criticalFlow.spec.ts:167:5
    at /home/runner/work/wire-webapp/wire-webapp/test/e2e_tests/criticalFlow.spec.ts:166:3

Copy link

@iskvortsov iskvortsov merged commit f23c6fe into dev Jun 25, 2025
13 of 15 checks passed
@iskvortsov iskvortsov deleted the chore/WPB-18373_Refactored-PageObject-implementation branch June 25, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants