refactor: migrate tests to testing-library #13833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PatrykBuniX
commented
Oct 10, 2022
PatrykBuniX
commented
- migrate last portion of tests to testing library,
- fix some of the ts strict errors along the way
- delete TestPage util 😄
Codecov Report
@@ Coverage Diff @@
## dev #13833 +/- ##
==========================================
+ Coverage 38.96% 39.06% +0.09%
==========================================
Files 569 569
Lines 21069 21064 -5
Branches 4551 4548 -3
==========================================
+ Hits 8210 8229 +19
+ Misses 11875 11848 -27
- Partials 984 987 +3 |
przemvs
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.