runfix: refactor tests and fix ts strict errors #13781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #13781 +/- ##
==========================================
- Coverage 39.08% 39.07% -0.01%
==========================================
Files 568 568
Lines 21044 21050 +6
Branches 4543 4546 +3
==========================================
+ Hits 8225 8226 +1
- Misses 11836 11839 +3
- Partials 983 985 +2 |
atomrc
suggested changes
Oct 3, 2022
| @@ -41,11 +41,11 @@ const CallMessage: React.FC<CallMessageProps> = ({message}) => { | |||
| <div className="message-header"> | |||
| <div className="message-header-icon message-header-icon--svg"> | |||
| {isCompleted ? ( | |||
| <div className="svg-green"> | |||
| <div data-uie-name="pickup-icon" className="svg-green"> | |||
There was a problem hiding this comment.
Let's not use uie-names only for our unit test. They have a meaning for QA, so we should try to have only qa related ones in the code.
Instead, I'd suggest you mock the Icon and render a specific text (instead of the actual icon) and use getByText. You can inspire from this (https://github.com/wireapp/wire-webapp/blob/dev/src/script/components/MessagesList/Message/CallMessage.test.tsx#L25) (but avoiding using the class here, rather some text).
jest.mock('Components/Icon', () => ({
Hangup: function HangupIcon() {
return <span>hangupIcon</span>;
},
Pickup: function PickupIcon() {
return <span>pickupIcon</span>;
},
}));And later:
getByText('hangupIcon')
atomrc
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate some tests to testing-library and fix some ts errors along the way.