fix: Improve ws connection reliability [FS-803 FS-1037] #13779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomrc
changed the title
atomrc
commented
Oct 3, 2022
| onEvent: this.handleIncomingEvent, | ||
| onMissedNotifications: this.triggerMissedSystemEventMessageRendering, | ||
| onNotificationStreamProgress: ({done, total}) => { | ||
| amplify.publish(WebAppEvents.WARNING.SHOW, Warnings.TYPE.CONNECTIVITY_RECOVERY); |
There was a problem hiding this comment.
This was a mistake. It triggered the banner everytime we process one message from the notification stream.
Not a big deal, since it's reduced to 1 event, but semantically incorrect
atomrc
commented
Oct 3, 2022
Comment on lines
+140
to
+143
| case ConnectionState.PROCESSING_NOTIFICATIONS: { | ||
| amplify.publish(WebAppEvents.WARNING.DISMISS, Warnings.TYPE.NO_INTERNET); | ||
| amplify.publish(WebAppEvents.WARNING.DISMISS, Warnings.TYPE.CONNECTIVITY_RECONNECT); | ||
| amplify.publish(WebAppEvents.WARNING.SHOW, Warnings.TYPE.CONNECTIVITY_RECOVERY); |
There was a problem hiding this comment.
Now the processing of notification stream gets a clean new lifecycle event.
We can now handle all the banner displaying in this single method
PatrykBuniX
approved these changes
Oct 3, 2022
thisisamir98
approved these changes
Oct 3, 2022
Codecov Report
@@ Coverage Diff @@
## dev #13779 +/- ##
==========================================
- Coverage 39.08% 39.08% -0.01%
==========================================
Files 568 568
Lines 21044 21045 +1
Branches 4543 4544 +1
==========================================
Hits 8225 8225
- Misses 11836 11837 +1
Partials 983 983 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will use the new lifecycle hook of the
listenmethod to display the internet state banner.This should: