Skip to content

build: update microdata-node and add tests #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
Merged

build: update microdata-node and add tests #118

merged 2 commits into from
Mar 4, 2025

Conversation

mvolz
Copy link
Collaborator

@mvolz mvolz commented Mar 1, 2025

Addresses #83 and #68

  • Add tests for schema.org microdata.
  • Clean up static html files a bit by adding more comments and indenting.

@jdforrester
Copy link
Member

Given there were two different issues filed related to this, should we add a regression test?

* Add schema.org microdata to turtle_article.html
and case sensitive tests.
 ** Includes self-closing tags, href attr, content attr,
and content taken from between tags
* Add test to ensure self-closing tags are parsed
correctly.
@mvolz
Copy link
Collaborator Author

mvolz commented Mar 4, 2025

Good catch. We in fact had no tests for schema.org in html, only for schema.org in json-ld.

@mvolz mvolz changed the title build: update microdata-node build: update microdata-node and add tests Mar 4, 2025
@jdforrester jdforrester merged commit f743b46 into main Mar 4, 2025
3 checks passed
@jdforrester jdforrester deleted the microdata branch March 4, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants