[BREAKING CHANGE] Remove support for callback (node-style) requests #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bluebird Promises provides support for nodeifying this library. However bluebird use is now discouraged. In preperation for removing this library and switching to native JS Promises, remove support for callback style requests. Increment package.json to 3.0.0 to go along with documentation, but not ready for release yet, as this release is planned to remove the bluebird library entirely.
foldleft
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bluebird Promises provides support for nodeifying this library. However bluebird library use is now discouraged in favour of native Node Promises. In preparation for removing this library and switching to native JS Promises, remove support for callback style requests.
Increment package.json to 3.0.0 to go along with documentation, but not ready for release yet, as this release is planned to remove the bluebird library entirely.