Skip to content

[BREAKING CHANGE] Remove preq from library #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025
Merged

[BREAKING CHANGE] Remove preq from library #110

merged 1 commit into from
Feb 6, 2025

Conversation

mvolz
Copy link
Collaborator

@mvolz mvolz commented Feb 4, 2025

Remove preq from library entirely and
replace with native fetch.

This is not backwards compatible if third
party users are a) using the parseAll function,
and b) other features of preq, such as
the internalUri parameter or wrapped errors;
see https://github.com/wikimedia/preq for more
details on how preq alters the Response
object.

Bug: T361602

@mvolz mvolz requested review from foldleft and divec February 4, 2025 12:14
@mvolz mvolz marked this pull request as draft February 6, 2025 11:15
Remove preq from library entirely and
replace with native fetch.

This is not backwards compatible if third
party users are a) using the parseAll function,
and b) other features of preq, such as
the internalUri parameter or wrapped errors;
see https://github.com/wikimedia/preq for more
details on how preq alters the Response
object.

Bug: T361602
@mvolz mvolz marked this pull request as ready for review February 6, 2025 11:22
@mvolz mvolz merged commit a3217be into main Feb 6, 2025
3 checks passed
@mvolz mvolz deleted the rempreq branch February 27, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants