Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable cookie path #46

Merged
merged 2 commits into from
Oct 9, 2020
Merged

Configurable cookie path #46

merged 2 commits into from
Oct 9, 2020

Conversation

dariogoetz
Copy link
Contributor

Makes the cookie's path configurable in the set_jwt_cookie_authentication_policy function. This allows the authentication endpoints to be at a different path than the endpoints to secure.

@dariogoetz dariogoetz mentioned this pull request Oct 8, 2020
Closed
@wichert wichert merged commit 75fa5c0 into wichert:master Oct 9, 2020
wichert added a commit that referenced this pull request Oct 9, 2020
@wichert
Rename path to cookie_path and document
2a35227 
refs #46
@wichert
Copy link
Owner

wichert commented Oct 9, 2020

Thanks! I made a few changes on top of your PR:

  • I renamed path to cookie_path to make it clearer that this is specific to the cookie configuration.
  • Allow configuring the cookie path via Pyramid settings.
  • Updated README to mention to new setting.

wichert added a commit that referenced this pull request Oct 9, 2020
@wichert
Update changelog. refs #46
893fbfa
@wichert wichert linked an issue Oct 9, 2020 that may be closed by this pull request
Make cookie path configurable #45
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make cookie path configurable
2 participants
@dariogoetz @wichert