Skip to content

Create triples output bug #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2024
Merged

Create triples output bug #11

merged 2 commits into from
Oct 9, 2024

Conversation

tomsmoker
Copy link
Member

Changed

  • Modified generate_triples function to skip creation of triples with empty head or tail values
  • Updated triple_to_dict function to potentially return None for invalid triples
  • Improved type hinting in graph.py to resolve mypy errors

Fixed

  • Prevented creation and return of triples with empty string values for head or tail

@tomsmoker tomsmoker added the bug Something isn't working label Oct 9, 2024
@tomsmoker tomsmoker merged commit 218304a into main Oct 9, 2024
2 checks passed
@tomsmoker tomsmoker deleted the create_triples_output_bug branch October 9, 2024 06:16
tomsmoker added a commit that referenced this pull request Oct 29, 2024
@tomsmoker
Merge pull request #11 from whyhow-ai/create_triples_output_bug
719b6eb 
Create triples output bug
tomsmoker pushed a commit that referenced this pull request Oct 29, 2024
Project organization (#11)
e15dbc8 
* Setup github workflows

* Update workflow

* Update workflow

* Update workflow

* Update workflow

* Update workflow

* Update workflow

* Update workflow

* Fix formatting issues

* Fix formatting issues

* Add example test

* Pull the Pydantic models from `llm.py` out into their own module

* Fix llm response model

* Fix formatting issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tomsmoker