Allow more characters in custom element names #7991

domenic · 2022-06-07T16:24:10Z

At least two implementers are interested (and none opposed):
- Gecko
- Chromium
Tests are written and can be reviewed and commented upon at:
- Allow more characters in custom element names web-platform-tests/wpt#52982
- https://chromium-review.googlesource.com/c/chromium/src/+/6615057
Implementation bugs are filed:
- Chrome: https://bugs.chromium.org/p/chromium/issues/detail?id=1334640
- Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1773312
- Safari: https://bugs.webkit.org/show_bug.cgi?id=241419

(See WHATWG Working Mode: Changes for more details.)

/custom-elements.html ( diff )
/infrastructure.html ( diff )

annevk

This looks good to me. I like how this simplifies things quite a bit and reduces our reliance on ABNF and derivatives.

annevk · 2022-06-08T06:55:29Z

Hmm, I guess 0th is technically correct, but I wonder if we are using that consistently. Perhaps we should support string[0] to make it less confusing?

domenic · 2022-06-08T15:15:24Z

I doubt we are using it consistently. But the algorithms in https://infra.spec.whatwg.org/#strings use it indirectly quite a lot, e.g. "Let potentialPrefixCodeUnit be the ith code unit of potentialPrefix." where i can be 0. And the plus side is that nobody will be confused by 0th, although they might be confused by first.

Allowing string[0] is a bit tricky IMO because it doesn't clarify whether that's code point or code unit. Maybe string[0]_cu and string[0]_cp, but that feels a bit like adding notation for notation's sake...

josepharhar · 2025-05-17T00:30:44Z

Thanks for removing the EBNF, it is much easier for me to read and implement this way!

This follows whatwg/dom#1079.

domenic · 2025-05-19T05:01:08Z

I've rebased this onto main. It was pretty straightforward.

source

This patch changes the parsing of custom element names in DOM APIs to allow more flexibility and better parity with the HTML parser. Spec PR: whatwg/html#7991 Bug: 40122442, 40228234 Change-Id: I516de464254c5413e5610aedc3a70a73ea236616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6559428 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1470050}

josepharhar · 2025-06-06T00:16:09Z

Here is a new WPT: web-platform-tests/wpt#52982

And here are WPT changes which haven't been upstreamed yet: https://chromium-review.googlesource.com/c/chromium/src/+/6615057

domenic · 2025-06-06T01:20:45Z

I'll plan on merging this and github.com/whatwg/dom/pull/1079 on Monday or Tuesday. Thanks @josepharhar for helping finish this up!!

Spec PR: whatwg/html#7991 Bug: 40122442, 40228234 Change-Id: I216706db819aee655c7e05fd492eed546f449a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6615057 Reviewed-by: David Baron <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1473709}

…names, a=testonly Automatic update from web-platform-tests Allow more characters in custom element names This patch changes the parsing of custom element names in DOM APIs to allow more flexibility and better parity with the HTML parser. Spec PR: whatwg/html#7991 Bug: 40122442, 40228234 Change-Id: I516de464254c5413e5610aedc3a70a73ea236616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6559428 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1470050} -- wpt-commits: 1f3beebca7401634153d6d14c00742b29edbd072 wpt-pr: 52982

…names, a=testonly Automatic update from web-platform-tests Update tests for relaxed custom element names Spec PR: whatwg/html#7991 Bug: 40122442, 40228234 Change-Id: I216706db819aee655c7e05fd492eed546f449a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6615057 Reviewed-by: David Baron <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1473709} -- wpt-commits: 2548f608722cd9df1243e8ed396e54ef18e44f0a wpt-pr: 53130

…names, a=testonly Automatic update from web-platform-tests Allow more characters in custom element names This patch changes the parsing of custom element names in DOM APIs to allow more flexibility and better parity with the HTML parser. Spec PR: whatwg/html#7991 Bug: 40122442, 40228234 Change-Id: I516de464254c5413e5610aedc3a70a73ea236616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6559428 Reviewed-by: Mason Freed <masonfchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1470050} -- wpt-commits: 1f3beebca7401634153d6d14c00742b29edbd072 wpt-pr: 52982 UltraBlame original commit: 5f66415665cd00458acf241f316cedd1bc60aa34

…names, a=testonly Automatic update from web-platform-tests Update tests for relaxed custom element names Spec PR: whatwg/html#7991 Bug: 40122442, 40228234 Change-Id: I216706db819aee655c7e05fd492eed546f449a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6615057 Reviewed-by: David Baron <dbaronchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1473709} -- wpt-commits: 2548f608722cd9df1243e8ed396e54ef18e44f0a wpt-pr: 53130 UltraBlame original commit: aacdeef158c7a37fb012b1d57748456534927886

…names, a=testonly Automatic update from web-platform-tests Allow more characters in custom element names This patch changes the parsing of custom element names in DOM APIs to allow more flexibility and better parity with the HTML parser. Spec PR: whatwg/html#7991 Bug: 40122442, 40228234 Change-Id: I516de464254c5413e5610aedc3a70a73ea236616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6559428 Reviewed-by: Mason Freed <masonfchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1470050} -- wpt-commits: 1f3beebca7401634153d6d14c00742b29edbd072 wpt-pr: 52982 UltraBlame original commit: 5f66415665cd00458acf241f316cedd1bc60aa34

…names, a=testonly Automatic update from web-platform-tests Update tests for relaxed custom element names Spec PR: whatwg/html#7991 Bug: 40122442, 40228234 Change-Id: I216706db819aee655c7e05fd492eed546f449a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6615057 Reviewed-by: David Baron <dbaronchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1473709} -- wpt-commits: 2548f608722cd9df1243e8ed396e54ef18e44f0a wpt-pr: 53130 UltraBlame original commit: aacdeef158c7a37fb012b1d57748456534927886

…names, a=testonly Automatic update from web-platform-tests Allow more characters in custom element names This patch changes the parsing of custom element names in DOM APIs to allow more flexibility and better parity with the HTML parser. Spec PR: whatwg/html#7991 Bug: 40122442, 40228234 Change-Id: I516de464254c5413e5610aedc3a70a73ea236616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6559428 Reviewed-by: Mason Freed <masonfchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1470050} -- wpt-commits: 1f3beebca7401634153d6d14c00742b29edbd072 wpt-pr: 52982 UltraBlame original commit: 5f66415665cd00458acf241f316cedd1bc60aa34

…names, a=testonly Automatic update from web-platform-tests Update tests for relaxed custom element names Spec PR: whatwg/html#7991 Bug: 40122442, 40228234 Change-Id: I216706db819aee655c7e05fd492eed546f449a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6615057 Reviewed-by: David Baron <dbaronchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1473709} -- wpt-commits: 2548f608722cd9df1243e8ed396e54ef18e44f0a wpt-pr: 53130 UltraBlame original commit: aacdeef158c7a37fb012b1d57748456534927886

domenic added normative change topic: custom elements Relates to custom elements (as defined in DOM and HTML) labels Jun 7, 2022

domenic requested a review from annevk June 7, 2022 16:24

annevk approved these changes Jun 7, 2022

View reviewed changes

annevk mentioned this pull request Jun 8, 2022

String indexing whatwg/infra#461

Open

domenic mentioned this pull request Jun 8, 2022

Allow more characters when creating various nodes whatwg/dom#1079

Merged

3 tasks

domenic added the needs tests Moving the issue forward requires someone to write tests label Jun 14, 2022

annevk mentioned this pull request Aug 23, 2022

Allow more characters in dataset? #8215

Open

Allow more characters in custom element names

8c1c925

This follows whatwg/dom#1079.

domenic force-pushed the pcne-loosening branch from 2eb1e2d to 8c1c925 Compare May 19, 2025 05:00

annevk approved these changes May 19, 2025

View reviewed changes

source Show resolved Hide resolved

source Outdated Show resolved Hide resolved

Fix nits

4c724aa

chromium-wpt-export-bot mentioned this pull request Jun 5, 2025

Allow more characters in custom element names web-platform-tests/wpt#52982

Merged

domenic removed the needs tests Moving the issue forward requires someone to write tests label Jun 6, 2025

domenic merged commit 78d2678 into main Jun 9, 2025
2 of 3 checks passed

domenic deleted the pcne-loosening branch June 9, 2025 04:47

chromium-wpt-export-bot mentioned this pull request Jun 13, 2025

Update tests for relaxed custom element names web-platform-tests/wpt#53130

Merged

domenic mentioned this pull request Jul 8, 2025

Remove XML name validation from dataset named property setter #11439

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Allow more characters in custom element names #7991

Allow more characters in custom element names #7991

Uh oh!

domenic commented Jun 7, 2022 •

edited by pr-preview bot

Loading

Uh oh!

annevk left a comment

Uh oh!

annevk commented Jun 8, 2022

Uh oh!

domenic commented Jun 8, 2022

Uh oh!

josepharhar commented May 17, 2025

Uh oh!

domenic commented May 19, 2025

Uh oh!

Uh oh!

Uh oh!

josepharhar commented Jun 6, 2025

Uh oh!

domenic commented Jun 6, 2025

Uh oh!

Uh oh!

Uh oh!

Allow more characters in custom element names #7991

Allow more characters in custom element names #7991

Uh oh!

Conversation

domenic commented Jun 7, 2022 • edited by pr-preview bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

annevk left a comment

Choose a reason for hiding this comment

Uh oh!

annevk commented Jun 8, 2022

Uh oh!

domenic commented Jun 8, 2022

Uh oh!

josepharhar commented May 17, 2025

Uh oh!

domenic commented May 19, 2025

Uh oh!

Uh oh!

Uh oh!

josepharhar commented Jun 6, 2025

Uh oh!

domenic commented Jun 6, 2025

Uh oh!

Uh oh!

Uh oh!

domenic commented Jun 7, 2022 •

edited by pr-preview bot

Loading