Skip to content

Properly create Uint8Array objects #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2025
Merged

Properly create Uint8Array objects #350

merged 4 commits into from
Apr 24, 2025

Conversation

annevk
Copy link
Member

@annevk annevk commented Apr 23, 2025

Also address a couple additional Infra nits I noticed along the way.

Fixes #150 (finally) and helps with #334.


Preview | Diff

Also address a couple additional Infra nits I noticed along the way.

Fixes #150 (finally) and helps with #334.
@annevk annevk requested a review from domenic April 23, 2025 17:08
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit. Nice.

@annevk annevk merged commit 2f2e812 into main Apr 24, 2025
2 checks passed
@annevk annevk deleted the annevk/uint branch April 24, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Need to define global used to create the ArrayBuffer and Uint8Array in TextEncoder's encode()
2 participants